JCS-Prod/ProtoTank
1
0
Fork 0
Code Issues Pull Requests Projects Releases Activity

Added missing virtual destructors

Browse Source
This commit is contained in:
JackCarterSmith 2024-12-29 20:37:49 +01:00
parent 4521ce27d5
commit bab7fc8f12
Signed by: JackCarterSmith
GPG Key ID: 832E52F4E23F8F24
5 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Engine/Graphics/UI.hpp
View File

@ -36,7 +36,7 @@ inline UI::~UI() {}
class CockpitUI final : public UI { class CockpitUI final : public UI {
public: public:
CockpitUI(unsigned int w, unsigned int h); CockpitUI(unsigned int w, unsigned int h);
~CockpitUI() {} ~CockpitUI() override {}
CockpitUI(CockpitUI&&) = default; CockpitUI(CockpitUI&&) = default;
CockpitUI& operator= (CockpitUI&&) = default; CockpitUI& operator= (CockpitUI&&) = default;
@ -54,7 +54,7 @@ private:
class WorldUI final : public UI { class WorldUI final : public UI {
public: public:
WorldUI(unsigned int w, unsigned int h, std::shared_ptr<Graphic3DRenderer>& engineInstance); WorldUI(unsigned int w, unsigned int h, std::shared_ptr<Graphic3DRenderer>& engineInstance);
~WorldUI() {} ~WorldUI() override {}
WorldUI(WorldUI&&) = default; WorldUI(WorldUI&&) = default;
WorldUI& operator= (WorldUI&&) = default; WorldUI& operator= (WorldUI&&) = default;

2
Engine/World/DbgCube.hpp
View File

@ -6,7 +6,7 @@
class ObjectDbgCube final : public WorldObjectAbstract<ObjectDbgCube> { class ObjectDbgCube final : public WorldObjectAbstract<ObjectDbgCube> {
public: public:
ObjectDbgCube(); ObjectDbgCube();
~ObjectDbgCube() {} ~ObjectDbgCube() override {}
private: private:

2
Engine/World/Tank.hpp
View File

@ -6,7 +6,7 @@
class Tank final : public WorldObjectAbstract<Tank> { class Tank final : public WorldObjectAbstract<Tank> {
public: public:
Tank(); Tank();
~Tank() {} ~Tank() override {}
private: private:

1
Engine/World/WorldObject.hpp
View File

@ -5,6 +5,7 @@
class WorldObject { class WorldObject {
public: public:
virtual ~WorldObject() = 0;
virtual const Mesh& GetObjectMesh() const = 0; virtual const Mesh& GetObjectMesh() const = 0;
virtual const size_t GetObjectVerticesCount() const = 0; virtual const size_t GetObjectVerticesCount() const = 0;
const M3D_MATRIX GetTransform() noexcept { const M3D_MATRIX GetTransform() noexcept {

2
Engine/World/WorldObject.tpp
View File

@ -1,6 +1,8 @@
#include "WorldObject.hpp" #include "WorldObject.hpp"
inline WorldObject::~WorldObject() {}
template<class D> template<class D>
inline WorldObjectAbstract<D>::~WorldObjectAbstract() {} inline WorldObjectAbstract<D>::~WorldObjectAbstract() {}