From b9789bc4c407f612d061060135d756ce06b38d22 Mon Sep 17 00:00:00 2001
From: Niels Moseley <n.a.moseley@gmail.com>
Date: Tue, 10 Oct 2017 02:55:49 +0200
Subject: [PATCH] serial/parallel multiplier now supports sign-magnitude
 coefficients

---
 verilog/spmul/spmul.v    | 15 ++++++++++-----
 verilog/spmul/spmul_tb.v |  3 ++-
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/verilog/spmul/spmul.v b/verilog/spmul/spmul.v
index 21b0bd1..b303a7a 100644
--- a/verilog/spmul/spmul.v
+++ b/verilog/spmul/spmul.v
@@ -50,12 +50,14 @@ module SPMUL (
         end
         else if (domul == 1)
             begin
-                if (coefreg[9] == 1'b1)
+                // note: leave coefreg[9] untouched
+                // as this is the sign bit...
+                if (coefreg[8] == 1'b1)
                     accumulator <= {accumulator[23:0], 1'b0} + sigreg;
                 else    
                     accumulator <= {accumulator[23:0], 1'b0};
                 
-                coefreg <= {coefreg[8:0], 1'b0};
+                coefreg[8:0] <= {coefreg[7:0], 1'b0};
             end
     end
            
@@ -131,13 +133,16 @@ module SPMUL (
                     end
                 4'b1010:
                     begin
-                        domul <= 1;
-                    end                    
+                        domul <= 0;
+                    end
                 4'b1011:
                     begin
                         domul <= 0;
                         done <= 1;
-                        result_out <= accumulator[23:8];
+                        if (coefreg[9] == 0)
+                            result_out <= {1'b0, accumulator[23:9]};
+                        else
+                            result_out <= {1'b1, ~accumulator[23:9]};
                         state <= 0;
                     end
                 default:
diff --git a/verilog/spmul/spmul_tb.v b/verilog/spmul/spmul_tb.v
index 1488f06..e2cf51f 100644
--- a/verilog/spmul/spmul_tb.v
+++ b/verilog/spmul/spmul_tb.v
@@ -29,7 +29,8 @@ module SPMUL_TB;
         clk    = 0;
         rst_an = 0;
         sig    = 16'h7FFF;
-        coef   = 10'h1FF;
+        //coef   = 10'h1FF;
+        coef   = 10'h3FF; // sign-magnitude
         start  = 0;
         #3
         rst_an = 1;