jackcartersmith/blackmagic
1
0
Fork 0
Code Issues Pull Requests Releases Activity

usb: Simplify TOG_SET_REG_BIT_MSK_AND_SET

Browse Source 
A xor B with B=0 is A, thus this should be correct and faster.
This commit is contained in:
Urja Rannikko 2016-07-31 13:39:08 +03:00 committed by Karl Palsson
parent 599dd43190
commit 62b02c515f
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
include/libopencm3/stm32/tools.h
View File

@ -56,12 +56,7 @@
#define TOG_SET_REG_BIT_MSK_AND_SET(REG, MSK, BIT, EXTRA_BITS) \
do { \
register uint16_t toggle_mask = GET_REG(REG) & (MSK); \
register uint16_t bit_selector; \
for (bit_selector = 1; bit_selector; bit_selector <<= 1) { \
if ((bit_selector & (BIT)) != 0) { \
toggle_mask ^= bit_selector; \
} \
} \
toggle_mask ^= BIT; \
SET_REG((REG), toggle_mask | (EXTRA_BITS)); \
} while (0)