From 2427ee12fdecf29734c04ccdfb4b1381d13afac7 Mon Sep 17 00:00:00 2001
From: otavepto <otavepto@noreply.com>
Date: Fri, 22 Mar 2024 19:31:24 +0200
Subject: [PATCH] * use const ref for get/set env var * lock global mutex when
 generating steam api call id

---
 dll/base.cpp   | 10 ++++++----
 dll/dll/base.h |  4 ++--
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/dll/base.cpp b/dll/base.cpp
index 7415cdda..a6a7503c 100644
--- a/dll/base.cpp
+++ b/dll/base.cpp
@@ -29,7 +29,7 @@ void randombytes(char *buf, size_t size)
     
 }
 
-std::string get_env_variable(std::string name)
+std::string get_env_variable(const std::string &name)
 {
     wchar_t env_variable[1024]{};
     DWORD ret = GetEnvironmentVariableW(utf8_decode(name).c_str(), env_variable, _countof(env_variable));
@@ -41,7 +41,7 @@ std::string get_env_variable(std::string name)
     return utf8_encode(env_variable);
 }
 
-bool set_env_variable(std::string name, std::string value)
+bool set_env_variable(const std::string &name, const std::string &value)
 {
     return SetEnvironmentVariableW(utf8_decode(name).c_str(), utf8_decode(value).c_str());
 }
@@ -76,7 +76,7 @@ void randombytes(char *buf, size_t size)
   }
 }
 
-std::string get_env_variable(std::string name)
+std::string get_env_variable(const std::string &name)
 {
     char *env = getenv(name.c_str());
     if (!env) {
@@ -86,7 +86,7 @@ std::string get_env_variable(std::string name)
     return std::string(env);
 }
 
-bool set_env_variable(std::string name, std::string value)
+bool set_env_variable(const std::string &name, const std::string &value)
 {
     return setenv(name.c_str(), value.c_str(), 1) == 0;
 }
@@ -119,6 +119,8 @@ CSteamID generate_steam_anon_user()
 
 SteamAPICall_t generate_steam_api_call_id() {
     static SteamAPICall_t a;
+    std::lock_guard<std::recursive_mutex> lock(global_mutex);
+    
     randombytes((char *)&a, sizeof(a));
     ++a;
     if (a == 0) ++a;
diff --git a/dll/dll/base.h b/dll/dll/base.h
index 4b741dd9..6a070c32 100644
--- a/dll/dll/base.h
+++ b/dll/dll/base.h
@@ -32,8 +32,8 @@ extern const std::chrono::time_point<std::chrono::high_resolution_clock> startup
 extern const std::chrono::time_point<std::chrono::system_clock> startup_time;
 
 void randombytes(char *buf, size_t size);
-std::string get_env_variable(std::string name);
-bool set_env_variable(std::string name, std::string value);
+std::string get_env_variable(const std::string &name);
+bool set_env_variable(const std::string &name, const std::string &value);
 bool check_timedout(std::chrono::high_resolution_clock::time_point old, double timeout);
 
 class CCallbackMgr