From 896dfd736f107ae8cda898dbc3e68e3e1cf2a3c6 Mon Sep 17 00:00:00 2001 From: otavepto Date: Fri, 8 Mar 2024 21:28:17 +0200 Subject: [PATCH] revert the initial delay for the overlay renderer detector back to 0 --- CHANGELOG.md | 2 +- dll/dll/settings.h | 2 +- post_build/README.release.md | 6 +++--- .../overlay_hook_delay_sec.EXAMPLE.txt | 2 +- .../overlay_renderer_detector_timeout_sec.EXAMPLE.txt | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5efc6194..96fde264 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ * for Linux: new experimental build of the emu with overlay support currently only *some* 64-bit games using OpenGL will work * use a new method to initialize the overlay on a separate thread with a configurable initialization delay and renderer detection timeout - - the new config file `overlay_hook_delay_sec.txt` controls the initial delay (default = `5 seconds`) + - the new config file `overlay_hook_delay_sec.txt` controls the initial delay (default = `0 seconds`) - the new config file `overlay_renderer_detector_timeout_sec.txt` controls the detection timeout (default = `15 seconds`) check the updated `README` diff --git a/dll/dll/settings.h b/dll/dll/settings.h index a3e6be81..4b0ba359 100644 --- a/dll/dll/settings.h +++ b/dll/dll/settings.h @@ -283,7 +283,7 @@ public: //overlay bool disable_overlay = false; - int overlay_hook_delay_sec = 5; // "Saints Row (2022)" needs a lot of time to initialize, otherwise detection will fail + int overlay_hook_delay_sec = 0; // "Saints Row (2022)" needs a lot of time to initialize, otherwise detection will fail int overlay_renderer_detector_timeout_sec = 15; // "Saints Row (2022)" takes almost ~8 sec to detect renderer (DX12) bool disable_overlay_achievement_notification = false; bool disable_overlay_friend_notification = false; diff --git a/post_build/README.release.md b/post_build/README.release.md index 884a2aa9..f1e374a5 100644 --- a/post_build/README.release.md +++ b/post_build/README.release.md @@ -519,16 +519,16 @@ Also, match making servers will return the info of the server from the incoming **Note: at the moment this feature is only enabled in the experimental builds** --- -By default the emu will wait `5 seconds` before attempting to start the overlay renderer detector, this allows some games to initialize properly, otherwise the detector may not detect the current renderer (DirectX, OpenGL, etc...) and the overlay will not work (example games: `Have a Nice Death`, `Saints Row (2022)`). +By default the emu will immediately start the renderer detector for the overlay, but you can give it some initial delay, +which allows some games to initialize properly, otherwise the detector may not detect the current renderer (DirectX, OpenGL, etc...) and the overlay will not work (example games: `Have a Nice Death`, and `Saints Row (2022)`). After that initial delay, the emu will give the detector `15 seconds` as a timeout, after that time if the detector didn't return a valid result, it will fail. This avoids an infinite detection loop and a potential FPS drop on failure. You can control these timings via the configuration files: * `overlay_hook_delay_sec.txt`: controls the amount of seconds to wait for initially before attempting the detection. -* `overlay_renderer_detector_timeout_sec.txt`: controls the timeout (in seconds) of the detection. +* `overlay_renderer_detector_timeout_sec.txt`: controls the timeout of the detection, in seconds. -It is **NOT** recommended to remove these timings or setting them to 0. Negative values will be ignored, also the renderer detector timeout cannot be 0. Check the example files in the `steam_settings` folder diff --git a/post_build/steam_settings.EXAMPLE/overlay_hook_delay_sec.EXAMPLE.txt b/post_build/steam_settings.EXAMPLE/overlay_hook_delay_sec.EXAMPLE.txt index 7813681f..3f10ffe7 100644 --- a/post_build/steam_settings.EXAMPLE/overlay_hook_delay_sec.EXAMPLE.txt +++ b/post_build/steam_settings.EXAMPLE/overlay_hook_delay_sec.EXAMPLE.txt @@ -1 +1 @@ -5 \ No newline at end of file +15 \ No newline at end of file diff --git a/post_build/steam_settings.EXAMPLE/overlay_renderer_detector_timeout_sec.EXAMPLE.txt b/post_build/steam_settings.EXAMPLE/overlay_renderer_detector_timeout_sec.EXAMPLE.txt index 3f10ffe7..410b14d2 100644 --- a/post_build/steam_settings.EXAMPLE/overlay_renderer_detector_timeout_sec.EXAMPLE.txt +++ b/post_build/steam_settings.EXAMPLE/overlay_renderer_detector_timeout_sec.EXAMPLE.txt @@ -1 +1 @@ -15 \ No newline at end of file +25 \ No newline at end of file